[alexg]

Ok, if you do a binary search on the other plugins and try to pinpoint which one is causing this, then this can guide me in the right direction.

Deactivate half plugins, then see if the offending plugin is in the active ones. If it is, then deactivate half of the active ones and check again. If it’s not, try activating half of the deactivated ones. If you can do this until you determine which one it is, then let me know which plugin is causing the timeouts and I’ll test to see what the problem is. If you have N plugins you will have to do at most base 2 log N tries I think.

It could be some security plugin or caching plugin.

Unfortunately I can’t help in any other way unless you can at least pinpoint the plugin. If you do, I’ll look into the plugin and find the problem.

Good luck, let me know.

[alexg]

Hello,

Thank you for reporting this.

1. 524 is the cloudflare-specific HTTP error code. Did you try without cloudflare?

2. After activating, did you try refreshing the page several times?

3. Did you try activating with all other plugins disabled?

4. What’s in your PHP error logs?

Let me know please, thank you.

with regards

[alexg]

Hello,

Regarding the first issue, it sounds like some CSS is needed. If you want me to take a look, send me a link to the page.

Regarding the second issue, the plugin tries to attach the UI to various custom post types, however this is not always possible. In the case of forums, there are usually specialized WordPress templates for displaying each forum/topic. You can try to use one of the following PHP tags in such a template:

– The shortcode [wallets_tips]
– The PHP tag <?php do_action( 'wallets_tips' ); ?>

Use one of the above inside the HTML that draws the forum page.

Hope this helps. Let me know if you have any questions or if you want me to look at your page’s CSS.

with regards

P.S. I have moved your post to the correct forum for this extension.

[alexg]

Hello,

Unfortunately tron and solana chains are not yet available. This is because I have not implemented gas management for these chains, only for BSC and Ethereum. Without gas management, deposits will get stuck.

The cron job that creates Currencies from the CoinPayments settings skips any currencies except for main chain coins, and tokens on BSC or Ethereum.

with regards

[alexg]

Hello,

Thank you for the logs. The issue is unrelated to your cache.

The plugin is trying to lock the wallet after the withdrawals. But it is not encrypted, and for that reason the plugin is failing to lock the wallet. It then assumes that the withdrawal failed. I will patch this for the next release. Thank you for reporting this issue.

It is not recommended to use an unencrypted wallet. It’s better to encrypt your wallet and give the passphrase to the plugin. This way, if the wallet file is stolen from your server, it cannot be opened, unless the attacker has also obtained the passphrase from the WordPress DB. If you set a passphrase this issue will not occur.

You can use the “encryptwallet” CLI command to encrypt your wallet with a passphrase. Then, enter this passphrase in the wallet adapter.

Regarding the negative balance arising from using the exchange: I will need a lot more information than that. Please open a new thread in the Exchange forum, or email me with more details.

Was this a test you did? What trades did you perform? What do the user transactions look like, user trades, order history, etc.

Thank you.

with regards

[alexg]

Oh no, this sounds rather serious. I’m sorry about that. I hope you only lost Litecoin testnet coins or a small amount of funds.

Normally the plugin has protections against this kind of thing.

Did you manage to gather logs? To do this, please enable logging in: Settings → Bitcoin and Altcoin Wallets → Cron tasks → Verbose logging. When a withdrawal next occurs, this is the log output that will tell us what happened.

I have a theory for why this happened, but I’m not sure without looking at logs: The plugin first checks for sufficient balance, then proceeds to withdraw. If you got a negative balance out of this, then that means multiple cron tasks ran concurrently. Normally the plugin guards against this with semaphores: https://github.com/dashed-slug/wallets/blob/6.0.0-RC4/cron/abstract-task.php#L204-L220

However the semaphores are implemented as transients. Depending on your cache settings, transients may be unreliable, and I may need to change them to options.

Can you please tell me the following:

1. Did the negative balance occur on the user who owns the withdrawal and for the currency of the withdrawal? Or is this an unrelated incident?

2. Do you have verbose logs from a withdrawal run (while there are still funds to withdraw)?

3. What server-side caching plugin do you use?

You can “fix” the negative balance for the user if you create a new “deposit” or “move” transaction for that user (Transactions → New). The transaction needs to be created in two steps. First create and save the transaction with the desired user and currency, then set the amount to add to the user’s balance, and save again. However this will not return the funds to your site, it will only amend the user’s balance.

Remember, this is an RC version and issues are to be expected. It’s not yet suitable for production. Thank you for reporting this.

P.S. I have moved your post in a new thread since it is unrelated to your previous query.

[alexg]

Hello,

In your example, the user cannot expect to withdraw 1 BTC, since their balance is only 0.995 BTC after the deposit fee paid to CoinPayments.

As for the withdrawal fee, again, I still don’t see why it has to be proportional. The withdrawal fee imposed by CoinPayments is a fixed amount, not related to the transacted amount.

Whether the CoinPayments fee is high or low is besides the point. The CoinPayments platform imposes this fee; you and I have no say on it, unfortunately.

I hope to build more adapters that use different alternatives in the future, but some other things must happen beforehand.

In the meantime, if a developer is interested in creating an alternative adapter and sell it, they can do so. I have provided all the necessary information on wallet adapter development and example code, and am happy to answer questions on how to do it.

Please let me know if I am wrong about this.

[alexg]

Hello,

OK, good to hear that.

By the time the next version is out, it will be possible to use the plugin along with other plugins that use the Parsedown library.

with regards

[alexg]

Hello,

The adapter is for communicating directly with Bitcoin core’s JSON-RPC API, not with the APIs that BitGo exposes.

This would require development of a separate BitGo adapter. I already have this in my backlog. Perhaps something for the future.

with regards

[alexg]

Hello,

This may be a valid point, but I’m not sure.

To be clear, when a user sends an amount to their deposit address, say 100 coins, CoinPayments retains 0.5% (A fee of 1% applies for tokens.). So the user would receive in this case 99.5 coins in their balance.

The plugin’s ledger would show an incoming deposit of 99.5 and a fee of 0.5 (the fee is paid to CoinPayments, not the WordPress site).

When the user later decides to withdraw the 99.5 coins, they will have to pay a withdrawal fee, which will cover the mining expenses. This fee is not proportional to the amount transacted, so there is no need for it to be a percentage.

With the change to wallets 6.0.0, I have moved the fee settings from the adapter’s settings to the currency settings. The proportional fee was confusing to many users so I didn’t think it was necessary to re-implement it.

Why do you think it’s necessary for the withdrawal fee to be proportional to the amount transacted? I don’t see how the site can lose funds. The “withdrawal fee” should cover the mining fee, which is unrelated to the amount transacted.

Please let me know your reasoning, because implementing a proportional fee is doable, but it’s something that has confused users in the past, and it would require significant effort, so I’m trying to understand the use case.

Thank you

with regards

[alexg]

Ah yes, thank you very much for reporting this.

It is partly my fault, and partly the fault of another plugin that you are using. Both plugins attempt to load the Parsedown library, and both plugins don’t check if the library is already loaded.

The issue is here: https://github.com/dashed-slug/wallets/blob/6.0.0-RC4/admin/documentation.php#L15-L16

I will correct this in the next release. In the meantime, you can delete these lines, then, further down in the file, where the library is being used, you can add the following:

if ( ! class_exists( 'Parsedown' ) ) {
    require_once DSWALLETS_PATH . '/third-party/Parsedown.php';
}

if ( ! class_exists( 'ParsedownExtra' ) ) {
    require_once DSWALLETS_PATH . '/third-party/ParsedownExtra.php';
}

right above the following code:

// render markdown
$pd = new \ParsedownExtra;
$html = $pd->text( $markdown );

Thank you for noticing and reporting this issue. I will apply the patch on the next version.

with regards

[alexg]

OK this is now fixed in version 6.0.0-RC4.

Again, a big thank you for reporting this! Please report any other issues if you see any.

[alexg]

Thank you very much for providing this information. I had not tested deposits with a non-zero deposit fee (oops!)

I will be uploading a version 6.0.0-RC4 today on this website. It resolves this issue, as well as some more that I have identified in the meantime.

[alexg]

Thank you for providing screenshots. Unfortunately I was not able to determine what the issue is.

Just to make sure that we are on the same page, I will summarise the issue so far. Please check that I have understood you correctly.

The plugin is not being notified immediately about incoming deposits.

You have added the following lines to your config file:

walletnotify=curl -s 'https://exchange.napocoin.net/wp-json/dswallets/v1/walletnotify/25335/%s' >/dev/null
blocknotify=curl -s 'https://exchange.napocoin.net/wp-json/dswallets/v1/blocknotify/25335/%s' >/dev/null

Where 25335 is the post_id of your Napocoin Currency entry.

When you logged in to your wallet server, you have attempted the following command:

curl ‘https://exchange.napocoin.net/wp-json/dswallets/v1/walletnotify/25335/ABCD’

and you get as result:

{"message":"The plugin is being notified about this TXID. If a user is associated with one of its output addresses, a deposit will be registered for this user.","status":"success"}

The above is to be expected when the TXID is invalid.

But if you try the same command with a correct TXID that corresponds to your deposit, then you see on the screen the message:

There has been a critical error on this website.

This may be due to a difference between napocoin and bitcoin JSON-RPC APIs. The difference could be something trivial.

The only way to be sure is to see the PHP error that occurs at the time when you run the curl command with the correct TXID.

Can you please find this error message? The error will be in your PHP error log, and also in wp-content/debug.log if logging is enabled.

Let me know if you can find the error.

with regards

[alexg]

Hello,

Thank you for providing screenshots regarding the above.

I am assuming you are using version 6.0.0-RC3.

The screenshots you provided are not from the plugin’s own editors. Can you please use the plugin’s built in editors?

Based on the trace you provided, the plugin is trying to load a wallet by its string name, rather than a post ID:

DSWallets\Wallet::load('bitcoin')

I am not sure how that can happen. The argument passed to Wallet::load() must be an integer, and the plugin’s editor does not allow you to associate a currency with anything other than a wallets_wallet post ID. 

I am guessing based on the screenshots you provided, that maybe you used another post meta editor to modify the currency post type? If so, please use the plugin’s own editor.

I am planning to upload a version RC4 with some bug fixes, and this should be the last RC before the final release. But I don’t think that any of the unreleased fixes apply to your particular bug.

(I am taking things slow because I lost a loved one this week and it’s still hard to concentrate on work. Sorry about that. As soon as possible, I plan to continue with the release plan and other planned improvements to the products and website.)

TL;DR The plugin should not ever be calling Wallet::load('bitcoin'). From the stack trace, it looks like you tried to save a currency with a wallet string bitcoin, which is incorrect. I think this is an issue related to you using another post meta editor.

Please let me know if this makes any sense?

with regards

P.S. I use this email for work, not the one at gmail.

[Author]

Posts